Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH v2 0/4] Deprecate "not allow as-is commit with i-t-a entries"

From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:53:01

On Thu, Feb 9, 2012 at 12:34 AM, Junio C Hamano [off-list ref] wrote:
Ok, the strategy part is now behind us, but I have this slight suspicion
(I didn't look at the code nor tried it out myself---I don't have time to
do this myself today) that using this codepath might result in a corrupt
cache-tree, whose entries point at a section of the index it covers as a
subtree of the whole project but with incorrect counters or something like
that.  It would be good to make sure this "just ignoring i-t-a" is doing
the right thing not to the resulting commit, but in the resulting index as
well, before we go forward with this change.
I looked a little bit and I think i-t-a entries do not break
cache-tree. CE_REMOVE ones might though because they are taken into
account in entry_count field, but they are not written down to file.
Will look into it tonight.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help