Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH v2 0/4] Deprecate "not allow as-is commit with i-t-a entries"

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:01

Nguyen Thai Ngoc Duy [off-list ref] writes:
2012/2/7 Junio C Hamano [off-list ref]:
quoted
But when I said "let's admit that this is just fixing an UI mistake, no
configuration, no options", I really meant it. Without the backward
compatiblity "For now please do not fix this bug for me and keep being
buggy until I get used to the non-buggy behaviour" fuss, which we never do
to any bugfix.
Ahh I missed something again. Your patch looks good too.
Ok, the strategy part is now behind us, but I have this slight suspicion
(I didn't look at the code nor tried it out myself---I don't have time to
do this myself today) that using this codepath might result in a corrupt
cache-tree, whose entries point at a section of the index it covers as a
subtree of the whole project but with incorrect counters or something like
that.  It would be good to make sure this "just ignoring i-t-a" is doing
the right thing not to the resulting commit, but in the resulting index as
well, before we go forward with this change.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help