Re: [PATCH 2/2] add a Makefile switch to avoid gettext translation in shell scripts
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:52:51
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH 2/2] add a Makefile switch to avoid gettext translation in shell scripts · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 2/2] add a Makefile switch to avoid gettext translation in shell scripts · Jonathan Nieder <hidden>
- 2016-06-15 · Re: [PATCH 2/2] add a Makefile switch to avoid gettext translation in shell scripts · Ævar Arnfjörð Bjarmason <hidden>
- 2016-06-15 · Re: [PATCH 2/2] add a Makefile switch to avoid gettext translation in shell scripts · Alex Riesen <hidden>
- 2016-06-15 · Re: [PATCH 2/2] add a Makefile switch to avoid gettext translation in shell scripts · Alex Riesen <hidden>
Junio C Hamano wrote:
Jonathan Nieder [off-list ref] writes:
quoted hunk ↗ jump to hunk
quoted
Nice implementation. I still don't understand why NO_GETTEXT=YesPlease should not imply this.Should be easy to do so, like this?diff --git a/Makefile b/Makefile index a782409..c4c1066 100644 --- a/Makefile +++ b/Makefile@@ -1521,6 +1521,7 @@ ifdef GETTEXT_POISON endif ifdef NO_GETTEXT BASIC_CFLAGS += -DNO_GETTEXT + USE_GETTEXT_SCHEME = fallthrough endif
Yep, that would make my worries about intuitive behavior evaporate. :) (Maybe "USE_GETTEXT_SCHEME ?= fallthrough" to make it easier to override in config.mak.) Thanks. I also would not actually mind the behavior without that tweak, as long as it's explained somewhere. Ciao, Jonathan