Thread (21 messages) flat view 21 messages, 8 authors, 2016-06-15

Re: [PATCH] attr: map builtin userdiff drivers to well-known extensions

From: Jeff King <hidden>
Date: 2016-06-15 22:52:41

On Thu, Dec 22, 2011 at 12:05:39AM -0000, Philip Oakley wrote:
The "*.m=matlab" does give better (proper) hunk headers as it picks
out the "^%%" comment line which starts a code block . For option 3
(ObjC) they are empty (which is poor). The plain vanila (default)
hunk headers are so-so.
Thanks for all of the detail. I think it comes down to the part I
quoted, though: it is indeed a disservice to matlab people to map "*.m"
to objc. So let's be conservative and not do that (projects can always
add their own gitattributes).

(Even before seeing your answer, I dropped it from the re-roll of my
patch that I sent, but this confirms to me that it was the right thing
to do).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help