Re: [PATCH v2] t4018: introduce test cases for the internal hunk header patterns
From: Johannes Sixt <hidden>
Date: 2016-06-15 22:52:40
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH v2] t4018: introduce test cases for the internal hunk header patterns · Thomas Rast <hidden>
Am 20.12.2011 03:42, schrieb Brandon Casey:
+int WRONG_global_variable;
Personally, I'm not a fan of this one. IMHO, global variable definitions need not be ignored. (But I can live with it.) But here are some more tests that I care about and that you can squash in. Signed-off-by: Johannes Sixt <redacted> --- t/t4018/broken_class_constructor.cpp | 3 +- t/t4018/broken_return_type_in_global_namespace.cpp | 16 ++++++++++++++ t/t4018/class_definition.cpp | 19 +++++++++++++++++ t/t4018/derived_class_definition.cpp | 20 ++++++++++++++++++ t/t4018/ignore_access_specifier.cpp | 22 ++++++++++++++++++++ 5 files changed, 79 insertions(+), 1 deletions(-) create mode 100644 t/t4018/broken_return_type_in_global_namespace.cpp create mode 100644 t/t4018/class_definition.cpp create mode 100644 t/t4018/derived_class_definition.cpp create mode 100644 t/t4018/ignore_access_specifier.cpp
diff --git a/t/t4018/broken_class_constructor.cpp b/t/t4018/broken_class_constructor.cpp
index 774c7f9..28c1bc8 100644
--- a/t/t4018/broken_class_constructor.cpp
+++ b/t/t4018/broken_class_constructor.cpp@@ -3,7 +3,8 @@ int WRONG_function_hunk_header_preceding_the_right_one (void) return 0; } -RIGHT_function_hunk_header::RIGHT_function_hunk_header (void) +RIGHT_function_hunk_header::RIGHT_function_hunk_header (int x) : + WRONG_member_initializer(x) { const char *msg = "ChangeMe"; printf("Hello, world, %s\n", msg);
diff --git a/t/t4018/broken_return_type_in_global_namespace.cpp b/t/t4018/broken_return_type_in_global_namespace.cpp
new file mode 100644
index 0000000..da9931b
--- /dev/null
+++ b/t/t4018/broken_return_type_in_global_namespace.cpp@@ -0,0 +1,16 @@ +int WRONG_function_hunk_header_preceding_the_right_one (void) +{ + return 0; +} + +::TypeInGlobalNamespace RIGHT_function_hunk_header() +{ + const char *msg = "ChangeMe"; + printf("Hello, world, %s\n", msg); + return 0; +} + +int WRONG_function_hunk_header_following_the_right_one (void) +{ + return 0; +}
diff --git a/t/t4018/class_definition.cpp b/t/t4018/class_definition.cpp
new file mode 100644
index 0000000..fc3df34
--- /dev/null
+++ b/t/t4018/class_definition.cpp@@ -0,0 +1,19 @@ +int WRONG_function_hunk_header_preceding_the_right_one (void) +{ + return 0; +} + +class RIGHT_class_name +{ + void WRONG_function_name_following_the_right_one() + { + const char *msg = "ChangeMe"; + printf("Hello, world, %s\n", msg); + return 0; + } +} + +int WRONG_function_hunk_header_following_the_right_one (void) +{ + return 0; +}
diff --git a/t/t4018/derived_class_definition.cpp b/t/t4018/derived_class_definition.cpp
new file mode 100644
index 0000000..b8501a5
--- /dev/null
+++ b/t/t4018/derived_class_definition.cpp@@ -0,0 +1,20 @@ +int WRONG_function_hunk_header_preceding_the_right_one (void) +{ + return 0; +} + +class RIGHT_class_name : + public WRONG_class_name_following_the_right_one +{ + void WRONG_function_name_following_the_right_one() + { + const char *msg = "ChangeMe"; + printf("Hello, world, %s\n", msg); + return 0; + } +} + +int WRONG_function_hunk_header_following_the_right_one (void) +{ + return 0; +}
diff --git a/t/t4018/ignore_access_specifier.cpp b/t/t4018/ignore_access_specifier.cpp
new file mode 100644
index 0000000..d865040
--- /dev/null
+++ b/t/t4018/ignore_access_specifier.cpp@@ -0,0 +1,22 @@ +int WRONG_function_hunk_header_preceding_the_right_one (void) +{ + return 0; +} + +class RIGHT_class_name +{ +public: +protected: +private: + void WRONG_function_name_following_the_right_one() + { + const char *msg = "ChangeMe"; + printf("Hello, world, %s\n", msg); + return 0; + } +} + +int WRONG_function_hunk_header_following_the_right_one (void) +{ + return 0; +}
--
1.7.8.216.g2e426