Thread (5 messages) flat view 5 messages, 4 authors, 2016-06-15

Re: [PATCH] t4018: introduce test cases for the internal hunk header patterns

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:40

Possibly related (same subject, not in this thread)

Brandon Casey [off-list ref] writes:
quoted
   * after the line that contains "RIGHT" token, there should be one (and
     only one) line that contains "ChangeMe". The test modifies this
     token to "IWasChanged", compares the original with the modified
     result, and expects the "RIGHT" token above appears on the hunk
     header.
Both good improvements.
Let's not call "ChangeMe" a *token*, as I think the easiest example would
look like the following and it would not use it as such.  Rephrasing it as
a "string" would be better.

    @@ ... @@ int RIGHT_function_hunk_header(void)

     int RIGHT_function_hunk_header(void)
     {
    -    const char *msg = "ChangeME";
    +    const char *msg = "IWasChanged";
         printf("Hello, world, %s\n", msg);
	 return 0;
     }
    @@ ...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help