Thread (63 messages) flat view 63 messages, 3 authors, 2016-06-15

Re: [PATCH v2 17/51] do_for_each_ref(): correctly terminate while processesing extra_refs

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:37

mhagger@alum.mit.edu writes:
quoted hunk ↗ jump to hunk
From: Michael Haggerty <redacted>

If the user-supplied function returns a nonzero value while processing
extra_refs, terminate without processing the rest of the list.

This probably has no practical importance, but makes the handling of
extra_refs a little bit more consistent with the handling of other
refs.

Signed-off-by: Michael Haggerty <redacted>
---
 refs.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/refs.c b/refs.c
index 579e4c3..fb6fe84 100644
--- a/refs.c
+++ b/refs.c
@@ -711,8 +711,11 @@ static int do_for_each_ref(const char *submodule, const char *base, each_ref_fn
 
 	struct ref_array *extra = &extra_refs;
 
-	for (i = 0; i < extra->nr; i++)
+	for (i = 0; i < extra->nr; i++) {
 		retval = do_one_ref(base, fn, trim, flags, cb_data, extra->refs[i]);
+		if (retval)
+			goto end_each;
+	}
Makes sense and everything up to this point looks sane.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help