[PATCH v2 00/51] ref-api-C and ref-api-D re-roll
From: <hidden>
Date: 2016-06-15 22:52:36
From: Michael Haggerty <redacted>
Following is a re-roll of the combination of the following patch
series:
ref-api-C == mh/ref-api-3 [1]
[PATCH v2 00/12] Use refs API more consistently
ref-api-D == mh/ref-api-take-2 [2]
[PATCH 00/28] Store references hierarchically in cache
ref-api-D-fix-v1 [3]
[PATCH] Fix "is_refname_available(): query only possibly-conflicting references"
It differs from the original patch series in the following ways:
* Re-rolled onto the current master.
* Combined some patches that logically belonged together but were
split in earlier series (mainly textual changes like variable
renamings); made other minor cleanups.
* Incorporated ref-api-D-fix-v1 into the commit that it was fixing.
* Removed any changes to the enforcement of refname checks. The
earlier patch series included some changes that slightly tightened
up the checks applied to refnames, and could therefore have
theoretically caused problems for people whose repositories
currently include invalid reference names. Following Junio's
suggestion, I separated those changes out of this patch series so
that they can be addressed separately.
Otherwise, this patch series includes the substance of the earlier
patch series, which is basically a change to storing reference-caches
hierarchically and reading loose references lazily. This, in turn,
brings big performance improvements for repositories with many
references (especially many loose references) [4].
[1] http://permalink.gmane.org/gmane.comp.version-control.git/184368
[2] http://permalink.gmane.org/gmane.comp.version-control.git/184382
[3] http://permalink.gmane.org/gmane.comp.version-control.git/185423
[4] http://permalink.gmane.org/gmane.comp.version-control.git/185541
Michael Haggerty (51):
struct ref_entry: document name member
refs: rename "refname" variables
refs: rename parameters result -> sha1
clear_ref_array(): rename from free_ref_array()
is_refname_available(): remove the "quiet" argument
parse_ref_line(): add docstring
add_ref(): add docstring
is_dup_ref(): extract function from sort_ref_array()
refs: change signatures of get_packed_refs() and get_loose_refs()
get_ref_dir(): change signature
resolve_gitlink_ref(): improve docstring
Pass a (ref_cache *) to the resolve_gitlink_*() helper functions
resolve_gitlink_ref_recursive(): change to work with struct ref_cache
repack_without_ref(): remove temporary
create_ref_entry(): extract function from add_ref()
add_ref(): take a (struct ref_entry *) parameter
do_for_each_ref(): correctly terminate while processesing extra_refs
do_for_each_ref_in_array(): new function
do_for_each_ref_in_arrays(): new function
repack_without_ref(): reimplement using do_for_each_ref_in_array()
names_conflict(): new function, extracted from is_refname_available()
names_conflict(): simplify implementation
is_refname_available(): reimplement using do_for_each_ref_in_array()
refs.c: reorder definitions more logically
free_ref_entry(): new function
check_refname_component(): return 0 for zero-length components
struct ref_entry: nest the value part in a union
refs.c: rename ref_array -> ref_dir
refs: store references hierarchically
sort_ref_dir(): do not sort if already sorted
refs: sort ref_dirs lazily
do_for_each_ref(): only iterate over the subtree that was requested
get_ref_dir(): keep track of the current ref_dir
refs: wrap top-level ref_dirs in ref_entries
get_packed_refs(): return (ref_entry *) instead of (ref_dir *)
get_loose_refs(): return (ref_entry *) instead of (ref_dir *)
is_refname_available(): take (ref_entry *) instead of (ref_dir *)
find_ref(): take (ref_entry *) instead of (ref_dir *)
read_packed_refs(): take (ref_entry *) instead of (ref_dir *)
add_ref(): take (ref_entry *) instead of (ref_dir *)
find_containing_direntry(): use (ref_entry *) instead of (ref_dir *)
search_ref_dir(): take (ref_entry *) instead of (ref_dir *)
add_entry(): take (ref_entry *) instead of (ref_dir *)
do_for_each_ref_in_dir*(): take (ref_entry *) instead of (ref_dir *)
sort_ref_dir(): take (ref_entry *) instead of (ref_dir *)
struct ref_dir: store a reference to the enclosing ref_cache
read_loose_refs(): take a (ref_entry *) as argument
refs: read loose references lazily
is_refname_available(): query only possibly-conflicting references
read_packed_refs(): keep track of the directory being worked in
repack_without_ref(): call clear_packed_ref_cache()
cache.h | 6 +-
refs.c | 1569 ++++++++++++++++++++++++++++++++++++++++----------------------
refs.h | 41 +-
3 files changed, 1041 insertions(+), 575 deletions(-)
--
1.7.8