Thread (36 messages) flat view 36 messages, 2 authors, 2016-06-15

Re: [PATCH 1/6] t3040 (subprojects-basic): modernize style

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:52:35

Ramkumar Ramachandra wrote:
Put the opening quote starting each test on the same line as the
test_expect_* invocation.  While at it:
I suspect the above description, while it does describe your patch,
does not describe the _reason_ that the patch exists or that someone
would want to apply it.  Isn't it something more like:

	Make the following changes pertaining to &&-chaining, for some
	good reason that I will describe:

	- ...

	While at it, clean up the style to fit the prevailing style.
	That means:

	- Put the opening quote starting each test on the same line as
	...

I didn't read over the patch again.  Has it changed since v1?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help