[PATCH 2/7] imap-send: don't check return value of git_getpass
From: Jeff King <hidden>
Date: 2016-06-15 22:52:35
Subsystem:
the rest · Maintainer:
Linus Torvalds
git_getpass will always die() if we weren't able to get input, so there's no point looking for NULL. Signed-off-by: Jeff King <redacted> --- Not a bug, but just useless code I noticed. imap-send.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/imap-send.c b/imap-send.c
index 4c1e897..227253e 100644
--- a/imap-send.c
+++ b/imap-send.c@@ -1213,10 +1213,6 @@ static int auth_cram_md5(struct imap_store *ctx, struct imap_cmd *cmd, const cha strbuf_addf(&prompt, "Password (%s@%s): ", srvc->user, srvc->host); arg = git_getpass(prompt.buf); strbuf_release(&prompt); - if (!arg) { - perror("getpass"); - exit(1); - } if (!*arg) { fprintf(stderr, "Skipping account %s@%s, no password\n", srvc->user, srvc->host); goto bail;
--
1.7.8.rc2.8.gf0f4f