Thread (17 messages) flat view 17 messages, 2 authors, 2016-06-15

Re: [PATCH 5/5] sequencer: revert d3f4628e

From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:52:28

Hi Jonathan,

Jonathan Nieder writes:
Is this patch just reverting a previous patch?  If so, why doesn't the
commit message use the usual format

       Revert "<commit message>"

       This reverts commit <unabbreviated object name>.

       <explanation>
[...]
I'd have loved to use 'git revert d3f4628e', but that ends up creating
a lot more work: recall the big move made by 1/5?  I'm trying to
"effectively port the inverse of the changes made by d3f4628e in
revert.c to sequencer.c" -- would you still like to see a git-revert
style commit message?  Don't you think it'll be misleading?

Sorry about the shoddy commit messages though: I'm polishing the
series now that I'm convinced that it's heading in the right
direction.  Hopefully, I'll have more to show soon.

Thanks.

-- Ram
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help