Thread (5 messages) flat view 5 messages, 2 authors, 2016-06-15

Re: [PATCH 2/2] fast-import: don't allow to note on empty branch

From: Sverre Rabbelier <hidden>
Date: 2016-06-15 22:52:05

Heya,

On Thu, Sep 22, 2011 at 21:47, Dmitry Ivankov [off-list ref] wrote:
'reset' command makes fast-import start a branch from scratch. It's name
is kept in lookup table but it's sha1 is null_sha1 (special value).
'notemodify' command can be used to add a note on branch head given it's
name. lookup_branch() is used it that case and it doesn't check for
null_sha1. So fast-import writes a note for null_sha1 object instead of
giving a error.

Add a check to deny adding a note on empty branch and add a corresponding
test.
Makes sense as well.

-- 
Cheers,

Sverre Rabbelier
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help