Re: [PATCH 1/2] fast-import: don't allow to tag empty branch

Heya,

On Thu, Sep 22, 2011 at 21:47, Dmitry Ivankov [off-list ref] wrote:

'reset' command makes fast-import start a branch from scratch. It's name
is kept in lookup table but it's sha1 is null_sha1 (special value).
'tag' command can be used to tag a branch by it's name. lookup_branch()
is used it that case and it doesn't check for null_sha1. So fast-import
writes a tag for null_sha1 object instead of giving a error.

Add a check to deny tagging an empty branch and add a corresponding test.

Makes sense to me.

-- 
Cheers,

Sverre Rabbelier