Thread (9 messages) flat view 9 messages, 2 authors, 2016-06-15

Re: [PATCH 3/3] fast-import: rename object_count to pack_object_count

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:52:03

Dmitry Ivankov wrote:
object_count is used to count objects that'll go to the current pack.
While object_count_by_* are used to count total amount of objects and
are not used to determine if current packfile is empty.

Rename (and move declaration) object_count to pack_object_count to
avoid possible confusion.
No strong opinion on this one.  I guess the important thing is that
you are moving the declaration to the group of declarations labelled as

	/* The .pack file being generated */

.  Is it important to rename the variable while at it (which will
disrupt other patches in flight using that variable if they exist)?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help