Thread (33 messages) flat view 33 messages, 2 authors, 2016-06-15

Re: [PATCH 09/18] revert: Don't create invalid replay_opts in parse_args

From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:51:44

Hi Christian,

Christian Couder writes:
... and we could remove the "set" variable like this:

       while ((this_opt = va_arg(ap, const char *))) {
               if (va_arg(ap, int))
                       break;
       }
Very elegant- I especially like this.
You've reduced this to simply checking if the while loop ended
properly, or broke (using a break statement) by checking the
conditional that drove the loop.

Thanks.

-- Ram
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help