Thread (33 messages) flat view 33 messages, 2 authors, 2016-06-15

Re: [PATCH 17/18] revert: Introduce --continue to continue the operation

From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:51:43

Hi Christian,

Christian Couder writes:
On Tuesday 02 August 2011 04:47:01 Christian Couder wrote:
quoted
We can simplify this loop using strchrnul() like this:
[...]
       for (i = 1; *p; i++) {
               struct commit *commit = parse_insn_line(p, opts);
               if (!commit)
                       return error(_("Could not parse line %d."), i);
               next = commit_list_append(commit, next);
               p = strchrnul(p, '\n');
               if (*p)
                       p++;
       }
Thanks for the valuable review.  I would have preferred to receive it
earlier in the development cycle than later- although I've queued this
along with other similar changes (error reporting/ stylistic changes;
not urgent), I'm not in favor of holding up the series.

Thank you.

-- Ram
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help