Thread (13 messages) flat view 13 messages, 2 authors, 2016-06-15

Re: [PATCH/WIP 4/7] fast-import: fix data corruption in store_tree

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:51:40

Dmitry Ivankov wrote:
quoted hunk ↗ jump to hunk
--- a/fast-import.c
+++ b/fast-import.c
@@ -1474,8 +1474,11 @@ static void store_tree(struct tree_entry *root)
 		return;
 
 	for (i = 0; i < t->entry_count; i++) {
-		if (t->entries[i]->tree)
-			store_tree(t->entries[i]);
+		if (!S_ISDIR(t->entries[i]->versions[1].mode))
+			continue;
+		if (!t->entries[i]->tree)
+			load_tree(t->entries[i]);
+		store_tree(t->entries[i]);
How can this load_tree call work if t->entries[i]->versions[1].sha1
is not already in the object database?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help