Thread (13 messages) flat view 13 messages, 2 authors, 2016-06-15

Re: [PATCH/WIP 3/7] fast-import: fix a data corruption in parse_ls

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:51:40

Dmitry Ivankov wrote:
store_tree sets versions[0] = versions[1] unconditionally. This is fine
if it is run from the very root.
True.
But if it's run for a intermediate
node in parse_ls, node's parent versions[0] can become invalid as it
references it's children versions[0].
A puzzle: when would parse_ls() call store_tree() on a subdirectory?
The store_tree() call is preceded by

	tree_content_get(root, p, &leaf);

which makes a deep copy of "root" in leaf (which seems to be leaked
--- oops).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help