Re: [PATCH 07/14] revert: Introduce struct to keep command-line options
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:51:34
Ramkumar Ramachandra wrote:
Since I'm not sure the function you propose will make it to sequencer.c, I don't want to introduce it now.
Wouldn't it be easy to remove such a function later?
Practically speaking, it is not obvious to me that making any of these
variables non-static is needed for "cherry-pick --continue" to work,
but given that most of the state is being made non-static anyway,
readers will be likely to wonder why "me" is left behind. So the
obvious choices would be to
a. make "me" a member of the replay_opts struct; or
b. compute "me" in each function that needs it by calling a helper
function; or
c. add some explanation to the commit message to clarify the status
of "me" as static-but-won't-be-in-the-long-term and a reason for
that
based on the needs of the current code. (b) sounds simplest to me,
though I haven't tried it.