Re: [PATCH/RFC 3/3] upload-archive: use start_command instead of fork

On Thu, Jul 7, 2011 at 8:21 PM, Johannes Sixt [off-list ref] wrote:

Am 07.07.2011 13:43, schrieb Erik Faye-Lund:

quoted

-     if (!enter_repo(buf, 0))
-             die("'%s' does not appear to be a git repository", buf);
-
      /* put received options in sent_argv[] */
      sent_argc = 1;
-     sent_argv[0] = "git-upload-archive";
+     sent_argv[0] = "archive";

Is git-archive a valid replacement of enter_repo() followed by
git-upload-archive?

What do you mean "enter_repo() followed by git-upload-archive"? Don't
you mean "enter_repo() followed by write_archive"? It does work for
me, and the test-suite didn't reveal any breakages either.

write_archive gets called by both versions, but my version doesn't
call enter_repo directly. It is however called by git-daemon before
starting git-upload-archive, so perhaps that's why it works for me.
And that's a regression indeed; I don't respect the path-argument. So
expect a new version over the week-end ;)