Thread (113 messages) flat view 113 messages, 3 authors, 2016-06-15

Re: [PATCH 02/15] tests: add GETTEXT_POISON to simulate unfriendly translator

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2016-06-15 22:50:37

On Mon, Feb 21, 2011 at 11:13, Jonathan Nieder [off-list ref] wrote:
 static inline FORMAT_PRESERVING(1) const char *_(const char *msgid)
 {
-       return msgid;
+       return use_poison() ? "Malkovich" : msgid;
 }
Why did you change this from "# GETTEXT POISON #" to "Malkovich"?

The reason it started with a "#" is because many rebase tests were
broken otherwise.

The reason it was in all caps was so that when I run the tests in
debug mode it's really easy to see at a glance if I'm encountering
these strings.

Do those tests still pass with this new string, and is there any
reason to change this?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help