Re: [PATCH/RFC 0/3] trace: omit noisy repository discovery report

2011/1/26 Jonathan Nieder [off-list ref]:

Nguyễn Thái Ngọc Duy wrote:

quoted

+++ b/trace.c

[...]

quoted

+     trace_printf("setup: git_dir: %s\n", quote_crnl(get_git_dir()));
+     trace_printf("setup: worktree: %s\n", quote_crnl(get_git_work_tree()));
+     trace_printf("setup: cwd: %s\n", quote_crnl(cwd));
+     trace_printf("setup: prefix: %s\n", quote_crnl(prefix));
+}

A few days ago I was tracing something or other and decided that these
extra lines are annoying.

Patch 1 moves this code from trace.c to git.c, to contain its impact
to a single translation unit (that is, it let me experiment without
touching cache.h after that).

Patch 2 removes the repo-setup tracing code, introducing a
test-repo-setup helper to take its place in the repo setup tests.

Patch 3 does some cleaning up made possible by patch 2.

Thoughts?

I'm fine with this. Although long term maybe we should support pattern
matching or category selection in GIT_TRACE.
-- 
Duy