Thread (63 messages) flat view 63 messages, 5 authors, 2016-06-15

Re: [PATCH 39/47] setup: limit get_git_work_tree()'s to explicit setup case only

From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:50:25

2011/1/18 Jonathan Nieder [off-list ref]:
How about something like this patch?  It only concerns the
GIT_WORK_TREE variable and --work-tree command line option; the
semantics of core.worktree are unaffected.
Perhaps only activate your code if $GIT_WORK_TREE is absolute path?
Things may go wild if $GIT_WORK_TREE is relative. We can die() if
GIT_WORK_TREE is set but not used. Annoying, but better than leave the
errors unseen.
(Sorry, no real patch yet.  Updating the test to reflect the change is
a pain in the neck.)
Yeah, I count on it to (over-)catch every mistakes in setup code :D
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help