[PATCH] imap-send: link against libcrypto for HMAC and others
STALE3764d
From: Diego Elio Pettenò <hidden>
Date: 2016-06-15 22:50:06
Subsystem:
kernel build + files below scripts/ (unless maintained elsewhere), the rest · Maintainers:
Nathan Chancellor, Nicolas Schier, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] imap-send: link against libcrypto for HMAC and others · Jared Hance <hidden>
- 2016-06-15 · Re: [PATCH] imap-send: link against libcrypto for HMAC and others · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] imap-send: link against libcrypto for HMAC and others · Anders Kaseorg <hidden>
- 2016-06-15 · Re: [PATCH] imap-send: link against libcrypto for HMAC and others · Junio C Hamano <hidden>
- 2016-06-15 · [PATCH] imap-send: link against libcrypto for HMAC and others · Diego Elio Pettenò <hidden>
When using stricter linkers, such as GNU gold or Darwin ld, transitive dependencies are not counted towards symbol resolution. If we don't link imap-send to libcrypto, we'll have undefined references to the HMAC_*, EVP_* and ERR_* functions families. Signed-off-by: Diego Elio Pettenò <redacted> --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 1f1ce04..c8377d4 100644
--- a/Makefile
+++ b/Makefile@@ -1927,7 +1927,7 @@ git-%$X: %.o $(GITLIBS) git-imap-send$X: imap-send.o $(GITLIBS) $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \ - $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) + $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO) git-http-fetch$X: revision.o http.o http-walker.o http-fetch.o $(GITLIBS) $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
--
1.7.3.2