Re: [PATCH] imap-send: link against libcrypto for HMAC and others
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:12
Jared Hance [off-list ref] writes:
quoted
You are both correct; the point of NO_OPENSSL is not to link with anything from openssl suite, so we need a separate mechanism to address this. Anders, wouldn't this be a better fix for NO_OPENSSL build, than reverting a fix for an incorrect ld invocation?Could we get this fixup patch into master? Leaving the original patch in without it doesn't seem like a good idea when it breaks the build.
That depends on what Diego and Anders would say/report, and that is why their address were on To/Cc in the message you are replying to. Why did you cull Cc from your message? One thing I do not like about it is that the "fixup" is ugly. It makes people expect to add $(LIB_4_CRYPTO) on their linker command line to get a correct linking with -lcrypto library, when all it does is _not_ to link with -lcrypto at all, so whatever program that uses it needs to know about NO_OPENSSL and refrain from using the symbols from that library.