Thread (18 messages) flat view 18 messages, 2 authors, 2016-06-15

Re: [RFC PATCH 1/6] msvc: opendir: use xmalloc

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:50:05

Erik Faye-Lund wrote:
The motivation is just to avoid having to deal with the error, like we
do other places. It's not a big deal though. I could also set errno to
ENOMEM and return NULL if that's preferable. I just don't see how it
is.
I don't disagree; just fishing for a commit message. :)
I also slightly dislike setting an error not listed in POSIX'
documentation of opendir, even though it's probably allowed.
For future reference, here's what POSIX has to say.

	Implementations shall not generate a different error
	number from one required by this volume of
	POSIX.1-2008 for an error condition described in this
	volume of POSIX.1-2008, but may generate additional
	errors unless explicitly disallowed for a particular
	function.

So ENOMEM would have been allowed from that front.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help