Re: [RFC PATCH 2/6] msvc: opendir: allocate enough memory

On Tue, Nov 23, 2010 at 6:42 PM, Jonathan Nieder [off-list ref] wrote:

Erik Faye-Lund wrote:

quoted

--- a/compat/msvc.c
+++ b/compat/msvc.c

@@ -5,12 +5,11 @@

 DIR *opendir(const char *name)
 {
-     int len;
+     int len = strlen(p->dd_name);
      DIR *p;

Does this work?

Whoops. It does work for me, but it shouldn't. I guess malloc is
over-allocating, and git is only using short paths.

Thanks for catching it.