Re: [PATCH 1/7] Teach fast-import to print the id of each imported commit
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:46
David Barr wrote:
quoted hunk ↗ jump to hunk
--- a/Documentation/git-fast-import.txt +++ b/Documentation/git-fast-import.txt@@ -92,6 +92,18 @@ OPTIONS --(no-)-relative-marks= with the --(import|export)-marks= options. +--report-fd=<fd>:: + Print the 40-character object name for each commit to + the specified file descriptor before writing it to the + pack.
This aspect (the printing of commit ids) of the report-fd feature is not used by the current svn-fe3 code. I'd suggest dropping it or at least making it optional; marks work pretty well for that purpose and it is not worth the cost or complication of making the frontend synchronize with fast-import with every commit.
quoted hunk ↗ jump to hunk
--- a/fast-import.c +++ b/fast-import.c@@ -361,6 +361,9 @@ static uintmax_t next_mark; static struct strbuf new_data = STRBUF_INIT; static int seen_data_command; +/* Where to report commits */ +static int report_fd = -1;
This aspect is still useful (for use by the cat command). :) Thanks.