Thread (42 messages) flat view 42 messages, 3 authors, 2016-06-15

Re: [PATCH 6/7] gitweb: group styling

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:49:33

Giuseppe Bilotta wrote:
2010/9/17 Jakub Narebski [off-list ref]:
quoted
On Thu, 16 Sep 2010, Giuseppe Bilotta wrote:
quoted
+div.group {
+     margin: .5em;
+     border: 1px solid #d9d8d1;
+     display: inline-block;
Is this 'display: inline-block;' really necessary?  I think we can do
without it (and I've heard that there are problems with it, but those
might not matter in layout used by gitweb).

Otherwise nice.
I'm not aware of problems with inline-block (I can check
quirksmode.org though if necessary), but without it the divs will be
as large as the _containing_ block, meaning that each div will be
ultimately as large as the page. By using inline-block, instead, they
become as large as the _contained_ stuff, thus fitting the inner
table.
Errr... I am using old web browser that doesn't support 'inline-block',
so I don't know what it should look like.  I'll check later.

But graceful degradation to 'block' doesn't look too bad.
-- 
Jakub Narebski
Poland
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help