Re: [PATCH 4/7] gitweb: link heads and remotes view

2010/9/17 Jakub Narebski [off-list ref]:

On Thu, 16 Sep 2010, Giuseppe Bilotta wrote:

quoted

Add a link in heads view to remotes view (if the feature is
enabled), and conversely from remotes to heads.

Good idea... but this commit message doesn't tell us *where* this link
do appear.  It is in lower part (the action specific part) of page
navigation menu.

I will clarify it in the next rehash of this patchset.

quoted

Signed-off-by: Giuseppe Bilotta <redacted>
---
 gitweb/gitweb.perl |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 0118739..6138c6e 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl

@@ -5511,7 +5511,10 @@ sub git_tags {

 sub git_heads {
      my $head = git_get_head_hash($project);
      git_header_html();
-     git_print_page_nav('','', $head,undef,$head);
+     my $heads_nav = gitweb_check_feature('remote_heads') ?
+             $cgi->a({-href => href(action=>"remotes", -replay=>1)},
+                     "remotes") : undef;

I think it would be more readable here to use 'if' statement instead
of conditional operator.

You're right. I'm actually thinking about putting 'tags' in that nav
menu too, as it makes sense to link to all refs commands there.

-- 
Giuseppe "Oblomov" Bilotta