Thread (12 messages) flat view 12 messages, 2 authors, 2016-06-15

Re: [PATCH v3 2/5] fmt-merge-msg: Make the number of log entries in commit message configurable

From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:49:21

Hi Jonathan,

Jonathan Nieder writes:
Hmm, this seems to be trying to have it both ways.  It would be simpler to
either:

	static int merge_summary;
	static int log_limit = 20;

providing independent internal "enabled" and "limit" knobs, so one could use,
say,

	[merge]
		log = 2
		log = false
		log = true

with the result being be a log_limit of 2, or

	static int log_limit;

where 0 means disabled, so in that example the result would be a log_limit
of 20.
[...]
What happened to the merge_summary argument?
This patch is roughly equivalent to my original log_limit patch. Yes,
I'm trying to have it both ways in this patch :) merge_summary is set
by both the command-line option and the config option, while log_limit
is set by the config option. As you noticed, the next patch removes
merge_summary.

-- Ram
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help