[PATCH v3 2/5] fmt-merge-msg: Make the number of log entries in commit message configurable
From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:49:21
Subsystem:
the rest · Maintainer:
Linus Torvalds
Make the `merge.log` option either an integer or boolean instead of just a boolean. The integer can be used to specify how many merged commits to summarize (at maximum) in the merge message. Let true mean 20. Default to false. Signed-off-by: Ramkumar Ramachandra <redacted> Reported-by: Yaroslav Halchenko <redacted> Thanks-to: Johannes Sixt [off-list ref] Thanks-to: Jonathan Nieder [off-list ref] --- builtin/fmt-merge-msg.c | 23 +++++++++++++++-------- 1 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/builtin/fmt-merge-msg.c b/builtin/fmt-merge-msg.c
index e7e12ee..e967a05 100644
--- a/builtin/fmt-merge-msg.c
+++ b/builtin/fmt-merge-msg.c@@ -12,16 +12,23 @@ static const char * const fmt_merge_msg_usage[] = { }; static int merge_summary; +static int log_limit = 0; static int fmt_merge_msg_config(const char *key, const char *value, void *cb) { static int found_merge_log = 0; + int is_bool = 0; if (!strcmp("merge.log", key)) { found_merge_log = 1; - merge_summary = git_config_bool(key, value); + log_limit = git_config_bool_or_int(key, value, &is_bool); } if (!found_merge_log && !strcmp("merge.summary", key)) - merge_summary = git_config_bool(key, value); + log_limit = git_config_bool_or_int(key, value, &is_bool); + + if (is_bool && log_limit) + log_limit = 20; + merge_summary = log_limit ? 1 : 0; + return 0; }
@@ -140,7 +147,7 @@ static void print_joined(const char *singular, const char *plural, } static void shortlog(const char *name, unsigned char *sha1, - struct commit *head, struct rev_info *rev, int limit, + struct commit *head, struct rev_info *rev, struct strbuf *out) { int i, count = 0;
@@ -169,7 +176,7 @@ static void shortlog(const char *name, unsigned char *sha1, continue; count++; - if (subjects.nr > limit) + if (subjects.nr > log_limit) continue; format_commit_message(commit, "%s", &sb, &ctx);
@@ -182,13 +189,13 @@ static void shortlog(const char *name, unsigned char *sha1, string_list_append(&subjects, strbuf_detach(&sb, NULL)); } - if (count > limit) + if (count > log_limit) strbuf_addf(out, "\n* %s: (%d commits)\n", name, count); else strbuf_addf(out, "\n* %s:\n", name); for (i = 0; i < subjects.nr; i++) - if (i >= limit) + if (i >= log_limit) strbuf_addf(out, " ...\n"); else strbuf_addf(out, " %s\n", subjects.items[i].string);
@@ -257,7 +264,7 @@ static void do_fmt_merge_msg_title(struct strbuf *out, static int do_fmt_merge_msg(int merge_title, int merge_summary, struct strbuf *in, struct strbuf *out) { - int limit = 20, i = 0, pos = 0; + int i = 0, pos = 0; unsigned char head_sha1[20]; const char *current_branch;
@@ -303,7 +310,7 @@ static int do_fmt_merge_msg(int merge_title, int merge_summary, for (i = 0; i < origins.nr; i++) shortlog(origins.items[i].string, origins.items[i].util, - head, &rev, limit, out); + head, &rev, out); } return 0; }
--
1.7.2.2.409.gdbb11.dirty