Re: [PATCH] hash: Remove useless init_hash()

 On 07/27/2010 12:58 PM, Ævar Arnfjörð Bjarmason wrote:

quoted

That being said, I agree with the comments that removing init_hash
actually makes the code _less_ readable. You could just replace these
three lines with a memset, but why? It's just code churn.

Yeah, and for the record it also missed this part in hash.c:

     void free_hash(struct hash_table *table)
     {
     	free(table->array);
     	table->array = NULL;
     	table->size = 0;
     	table->nr = 0;
     }

Have fun everyone :)

Ok, seems like nobody thinks this is a good idea so I'm fine with dropping it. The minimal savings (if at all) doesn't seem worth the code churn. One less patch in the queue ;-)