Re: [PATCH v3 09/13] print the line log

Bo Yang [off-list ref] writes:

+static void flush_lines(struct diff_options *opt, const char **ptr, const char *end,
+		int slno, int elno, int *lno, const char *color, const char heading)
+{
+	const char *p = *ptr;
+	struct strbuf buf = STRBUF_INIT;
+	const char *reset;
+
+	if (strcmp(color, ""))

Did you mean "if (*color)"?

+	/*
+	 * todo: when --graph landed on master, this should be changed
+	 * a little.
+	 */

Hmm, don't we already have it?

+static void diff_flush_filepair(struct rev_info *rev, struct diff_line_range *range)
+{
+...
+}

Looks suspiciously familiar...  Cut-and-paste without refactoring?