Re: [PATCH v3 02/13] parse-options: add two helper functions

Bo Yang [off-list ref] writes:

+int parse_options_next(struct parse_opt_ctx_t *ctx, int retain)

I think the latter is usually called "keep".

+{
+	if (ctx->argc <= 0)
+		return -1;
+
+	if (retain == 1)

Should this really check for "1", or would

	if (keep)

be more conventional?