Re: gitweb.perl suggestion

On Jul  8, Jakub Narebski wrote:

Eli Barzilay wrote:

quoted

On Jul  8, Jakub Narebski wrote:

quoted

So your proposed solution is good enough, but perhaps better would
be to leave 'action' unset if there is no parent info?  Then
dispatch would guess action, instead of doing it in less
sophisticated way in evaluate_path_info().

Ah, looking at the dispatch point, I see what you're talking about.
But that sounds like a larger change to the code -- since it would
probably lead to more default actions that get determined in dispatch
instead of earlier.

I don't remember if it was the real reson why
http://gitweb/project/<object> defaults to 'shortlog' action, but
<object> can be commit, but can be also tag.  The 'shortlog' action
makes sense for both... assuming that tag points to a commit object,
that is.

Ah, so it has to check the type of the object anyway...

P.S. As usual, patches welcome...

(I can turn that one-line change into a patch, but for anything more
substantial I'll actually need to deal with perl...)

-- 
          ((lambda (x) (x x)) (lambda (x) (x x)))          Eli Barzilay:
                    http://barzilay.org/                   Maze is Life!