Thread (5 messages) flat view 5 messages, 2 authors, 2016-06-15

Re: gitweb.perl suggestion

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:49:06

Eli Barzilay wrote:
On Jul  8, Jakub Narebski wrote:
quoted
So your proposed solution is good enough, but perhaps better would
be to leave 'action' unset if there is no parent info?  Then
dispatch would guess action, instead of doing it in less
sophisticated way in evaluate_path_info().
Ah, looking at the dispatch point, I see what you're talking about.
But that sounds like a larger change to the code -- since it would
probably lead to more default actions that get determined in dispatch
instead of earlier.
I don't remember if it was the real reson why http://gitweb/project/<object>
defaults to 'shortlog' action, but <object> can be commit, but can be also
tag.  The 'shortlog' action makes sense for both... assuming that tag
points to a commit object, that is.

P.S. As usual, patches welcome...
-- 
Jakub Narebski
Poland
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help