Re: [PATCH/RFC v3 0/7] Add internationalization support to Git

Am 6/2/2010 2:11, schrieb Ævar Arnfjörð Bjarmason:

    +export GIT_TEXTDOMAINDIR=`pwd`/../share/locale

This works only in some shells for two reasons:

- 'export foo=bar' syntax is not understood everywhere;

- if it is understood, then some shells still split the expansion in
'export foo=`pwd`' at white-space.

Use 'foo=bar; export foo', like you did elsewhere.

     test_expect_success 'sanity: $TEXTDOMAINDIR exists' '
    -	test -d $TEXTDOMAINDIR
    +	test -d $TEXTDOMAINDIR &&
    +	test $TEXTDOMAINDIR = $GIT_TEXTDOMAINDIR

Double-quotes, double-quotes!

-- Hannes