Re: [PATCH 1/4] gitweb: notes feature
From: Giuseppe Bilotta <hidden>
Date: 2016-06-15 22:48:10
On Thu, Feb 4, 2010 at 10:03 PM, Junio C Hamano [off-list ref] wrote:
AFAIU, the note code on the core side already creates a fan-out structure when notes tree gets large (see recent "What's cooking"; the series is parked in 'pu' but that is primarily because we are in feature freeze); it is not just "inherently not robust" but is much closer to "broken from day one" ;-). Otherwise I wouldn't have wasted time to point it out.
Ouch, I hadn't considered that, indeed.
Your code is a very good proof-of-concept, though.
Thanks. I guess at this point a proper implementation can wait for the necessary core support functions.
Regarding support of multiple notes hierarchies, listing, etc. See for example: http://thread.gmane.org/gmane.comp.version-control.git/138079/focus=138128 I expect more ideas from needs by end-user would come, as we gain experience with using notes in real projects. You will certainly find some other needs of your own, like the "not an environment but a command line option" which Jakub mentioned, and "multiple hierarchies" like both you and I found need for. Share them and let us together make the notes mechanism nicer to use.
Collecting those ideas together would also help define some sort of roadmap, or at least have a clear idea of what's needed, to help drive the design of the features themselves. Maybe we could start a TODO page on the wiki collecting these ideas? -- Giuseppe "Oblomov" Bilotta