Re: [PATCH 1/4] gitweb: notes feature
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:10
Giuseppe Bilotta [off-list ref] writes:
As I mentioned on the cover letter, I was hoping to be able to make something that could be deployable without requiring core changes and thus a specific minimum git version. I do realize however that this is inherently not robust (unless the code is updated if and when the notes storage mechanism changes).
AFAIU, the note code on the core side already creates a fan-out structure when notes tree gets large (see recent "What's cooking"; the series is parked in 'pu' but that is primarily because we are in feature freeze); it is not just "inherently not robust" but is much closer to "broken from day one" ;-). Otherwise I wouldn't have wasted time to point it out. Your code is a very good proof-of-concept, though. Regarding support of multiple notes hierarchies, listing, etc. See for example: http://thread.gmane.org/gmane.comp.version-control.git/138079/focus=138128 I expect more ideas from needs by end-user would come, as we gain experience with using notes in real projects. You will certainly find some other needs of your own, like the "not an environment but a command line option" which Jakub mentioned, and "multiple hierarchies" like both you and I found need for. Share them and let us together make the notes mechanism nicer to use. Thanks.