Re: [PATCH] Handle double slashes in make_relative_path()

lördagen den 23 januari 2010 14.09.29 skrev  Johannes Sixt:

On Samstag, 23. Januar 2010, Robin Rosenberg wrote:

quoted

It seems this function does something unhealthy when you pass a path of
the form //server/share. On windows dropping the double // at the
beginning makes it a different path since // is the UNC prefix.

There is no problem in practice.

The function returns either the input unmodified, or it strips also at
 least one directory component, except when base is only "/" (or "//" or
 "///"...). I said in practice, because on Windows it does not make sense
 to invoke git with (literally)

   git --git-dir=//server/share/repo.git --work-tree=/ ...

i.e., without a drive prefix before the slash of --work-tree.

Why not? //foo/bar/z is just as valid and useful a path as x:/z. 

Defining a drive-letter with msysgit is tricky because I have to find one that 
is available and then also restart every msys bash instance to make msys
see it.

-- robin