Thread (7 messages) flat view 7 messages, 4 authors, 2016-06-15

Re: [PATCH] Handle double slashes in make_relative_path()

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:48:05

Possibly related (same subject, not in this thread)

On Samstag, 23. Januar 2010, Robin Rosenberg wrote:
It seems this function does something unhealthy when you pass a path of the
form //server/share. On windows dropping the double // at the beginning
makes it a different path since // is the UNC prefix.
There is no problem in practice.

The function returns either the input unmodified, or it strips also at least 
one directory component, except when base is only "/" (or "//" or "///"...). 
I said in practice, because on Windows it does not make sense to invoke git 
with (literally)

   git --git-dir=//server/share/repo.git --work-tree=/ ...

i.e., without a drive prefix before the slash of --work-tree.

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help