Re: [PATCH] mingw: disable Python

On Fri, Jan 8, 2010 at 2:35 PM, Junio C Hamano [off-list ref] wrote:

Erik Faye-Lund [off-list ref] writes:

quoted

quoted

On Fri, 8 Jan 2010, Johannes Sixt wrote:

quoted

Erik Faye-Lund schrieb:

quoted

Python is not commonly installed on Windows machines, so
we should disable it there by default.

--- a/Makefile
+++ b/Makefile

@@ -1027,6 +1027,7 @@ ifneq (,$(findstring MINGW,$(uname_S)))
+   NO_PYTHON = YesPlease

I'm worried that with this solution it is impossible to re-enable Python
in config.mak (how do you undefine a Makefile variable?);

quoted

How about

       NO_PYTHON=

in config.mak?

That doesn't work for me, at least not out of the box. NO_PYTHON is
still defined, it's just defined to an empty string.

I think Dscho is right.  "ifdef FOO" yields (and should yield) false if
FOO is set to empty.

In that case I guess I messed up my test. I'll retest.

Yes, I messed up. "NO_PYTHON=" works like a charm.

So, no repost :)

-- 
Erik "kusma" Faye-Lund