Re: [PATCH] mingw: disable Python
From: Johannes Sixt <hidden>
Date: 2016-06-15 22:47:59
Erik Faye-Lund schrieb:
quoted hunk ↗ jump to hunk
Python is not commonly installed on Windows machines, so we should disable it there by default.--- a/Makefile +++ b/Makefile@@ -1027,6 +1027,7 @@ ifneq (,$(findstring MINGW,$(uname_S))) + NO_PYTHON = YesPlease
I'm worried that with this solution it is impossible to re-enable Python in config.mak (how do you undefine a Makefile variable?); it would be necessary to hack Makefile. Wouldn't it be superior to set PYTHON_PATH = in the MinGW section[*]. It works because there is this heuristic later: ifeq ($(PYTHON_PATH),) NO_PYTHON=NoThanks endif To enable Python, the user would have to set PYTHON_PATH in config.mak. [I have only Python 1.6 to test (doh!), so I can only tell that it gets used during 'make', but this fails due to missing modules, so I cannot tell whether there would be a usable result if Python were sufficiently recent.] [*] You should probably set the MSVC section as well, even if you cannot test it. The effect of the change is predictable enough, I think. -- Hannes