Re: [PATCH v3 2/6] t5541-http-push.sh: add test for unmatched, non-fast-forwarded refs
flat view
From: Jeff King <hidden>
Date: 2016-06-15 22:47:58
On Thu, Dec 24, 2009 at 03:41:58PM +0800, Tay Ray Chuan wrote:
Test that when non-fast-forwarded refs cannot be matched without an explicit refspect, the push fails with a non-fast-forward ref status and help message.
I don't understand what you're testing here. If it's not matched, then how is it a non-fast-forward? Isn't it simply unmatched? Your test:
quoted hunk ↗ jump to hunk
+test_expect_failure 'push fails for non-fast-forward refs unmatched by remote helper' ' + # create a dissimilarly-named ref so that git is unable to match the refs + git push origin master:retsam + + echo "change changed" > path2 && + git commit -a -m path2 --amend && + + # push master too. This ensures there is at least one '"'push'"' command to + # the remote helper and triggers interaction with the helper. + !(git push -v origin +master master:retsam >output 2>&1) && + + grep "^ + [a-z0-9]\+\.\.\.[a-z0-9]\+[ ]*master -> master (forced update)$" output && + grep "^ ! \[rejected\][ ]*master -> retsam (non-fast-forward)$" output &&
Looks like you're just testing the usual "master -> retsam is not a fast-forward" case. I don't understand how this is different from the previous tests. Can you elaborate? -Peff