(off-list ancestor, not in this archive)
[PATCH v2 0/3] transport: catch non-fast-forwards · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v2 1/3] refactor ref status logic for pushing · Tay Ray Chuan <hidden> · 2016-06-15
Re: [PATCH v2 1/3] refactor ref status logic for pushing · Daniel Barkalow <hidden> · 2016-06-15
Re: [PATCH v2 1/3] refactor ref status logic for pushing · Tay Ray Chuan <hidden> · 2016-06-15
Re: [PATCH v2 1/3] refactor ref status logic for pushing · Daniel Barkalow <hidden> · 2016-06-15
[PATCH v2 2/3] transport.c::transport_push(): make ref status affect return value · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v2 3/3] transport-helper.c::push_refs(): emit "no refs" error message · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v3 0/6] transport: catch non-fast forwards · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v3 1/6] t5541-http-push.sh: add tests for non-fast-forward pushes · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v3 2/6] t5541-http-push.sh: add test for unmatched, non-fast-forwarded refs · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v3 3/6] refactor ref status logic for pushing · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v3 4/6] transport.c::transport_push(): make ref status affect return value · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v3 5/6] transport-helper.c::push_refs(): ignore helper-reported status if ref is not to be pushed · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v3 6/6] transport-helper.c::push_refs(): emit "no refs" error message · Tay Ray Chuan <hidden> · 2016-06-15
Re: [PATCH v3 5/6] transport-helper.c::push_refs(): ignore helper-reported status if ref is not to be pushed · Jeff King <hidden> · 2016-06-15
Re: [PATCH v3 5/6] transport-helper.c::push_refs(): ignore helper-reported status if ref is not to be pushed · Tay Ray Chuan <hidden> · 2016-06-15
Re: [PATCH v3 5/6] transport-helper.c::push_refs(): ignore helper-reported status if ref is not to be pushed · Jeff King <hidden> · 2016-06-15
Re: [PATCH v3 5/6] transport-helper.c::push_refs(): ignore helper-reported status if ref is not to be pushed · Tay Ray Chuan <hidden> · 2016-06-15
Re: [PATCH v3 5/6] transport-helper.c::push_refs(): ignore helper-reported status if ref is not to be pushed · Tay Ray Chuan <hidden> · 2016-06-15
Re: [PATCH v3 2/6] t5541-http-push.sh: add test for unmatched, non-fast-forwarded refs · Jeff King <hidden> · 2016-06-15
Re: [PATCH v3 2/6] t5541-http-push.sh: add test for unmatched, non-fast-forwarded refs · Tay Ray Chuan <hidden> · 2016-06-15
Re: [PATCH v3 2/6] t5541-http-push.sh: add test for unmatched, non-fast-forwarded refs · Jeff King <hidden> · 2016-06-15
Re: [PATCH v3 2/6] t5541-http-push.sh: add test for unmatched, non-fast-forwarded refs · Junio C Hamano <hidden> · 2016-06-15
Re: [PATCH v3 2/6] t5541-http-push.sh: add test for unmatched, non-fast-forwarded refs · Tay Ray Chuan <hidden> · 2016-06-15

Re: [PATCH v2 1/3] refactor ref status logic for pushing

From: Daniel Barkalow <hidden>
Date: 2016-06-15 22:47:51

On Tue, 8 Dec 2009, Tay Ray Chuan wrote:

Move the logic that detects up-to-date and non-fast-forward refs to a
new function in remote.[ch], set_ref_status_for_push().

Is there some reason to not have set_ref_status_for_push() be static in 
transport.c now? (Sorry for not suggesting this before.)

Other than that, it looks good to me.

I think it might be a good idea to have it generate a peer ref for refs 
that don't have one when mirror is used, which would eliminate a couple 
more lines, but there's no reason that has to be done in the same patch.

	-Daniel
*This .sig left intentionally blank*

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help