Thread (9 messages) flat view 9 messages, 4 authors, 2016-06-15

Re: [PATCH v3] builtin-push: add --delete as syntactic sugar for :foo

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:57

Jan Krüger [off-list ref] writes:
Refspecs without a source side have been reported as confusing by many.
As an alternative, this adds support for commands like:

    git push origin --delete somebranch
    git push origin --delete tag sometag

Specifically, --delete will prepend a colon to all colon-less refspecs
given on the command line, and will refuse to accept refspecs with
colons to prevent undue confusion.

Signed-off-by: Jan Krüger <redacted>
---
Thanks.  From a cursory read, the patch looks good.  We would however want
to have a test that has test_must_fail to protect the error codepath from
getting broken in the future.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help