Thread (9 messages) flat view 9 messages, 4 authors, 2016-06-15

Re: [PATCH RFC v2] builtin-push: add --delete as syntactic sugar for :foo

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:56

Nanako Shiraishi [off-list ref] writes:
Junio, could you tell us what happened to this thread?

The patch implements "git push repo --delete branch" and rejects
--delete used with other options like --all and --tags, as suggested in
the initial review.  I think it makes sense, but nothing happens after
that.
Sverre cited an old discussion and the discussion stalled.  I just re-read
the thread, and think the "this is a wrong idea" objection was primarily
about allowing --delete with non-delete kinds of refspecs, so in that
sense Jan's patch is a perfected form of the Sverre's patch from that old
discussion.

As a summary of the lesson learned and concensus from the old discussion,
I agree with this from Sverre:

  http://article.gmane.org/gmane.comp.version-control.git/125901

namely, (1) barf and abort if src:dst is given; (2) touch only refs given
from the command line, "push there --delete" without any refspec is an
error; (3) be careful about "git push there tag v1.0.0" form.

So if Jan or Sverre want to resurrect the topic, I am all for it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help