Re: [REROLL PATCH v2 6/8] Support remote helpers implementing smart transports

Ilari Liusvaara [off-list ref] wrote:

Signed-off-by: Ilari Liusvaara <redacted>
Signed-off-by: Junio C Hamano <redacted>
Signed-off-by: Ilari Liusvaara <redacted>

This is better.

+	if (strcmp(name, exec)) {
+		r = set_helper_option(transport, "servpath", exec);
+		if (r > 0)
+			fprintf(stderr, "Warning: Setting remote service path "
+				"not supported by protocol.\n");
+		else if (r < 0)
+			fprintf(stderr, "Warning: Invalid remote service "
+				"path.\n");

Style-nit: We prefer "warning: " with lowercase.

-- 
Shawn.