Re: [PATCH] tests: handle NO_PYTHON setting
From: Brandon Casey <hidden>
Date: 2016-06-15 22:47:48
Jeff King wrote:
On Mon, Nov 30, 2009 at 12:07:40PM -0600, Brandon Casey wrote:
quoted
ps. There's something eerily familiar about this patch.Hmmm. Yes, I didn't search before writing it, but you probably mean: http://article.gmane.org/gmane.comp.version-control.git/127172
:) yeah, that was it, nbd.
But that is missing the NO-PYTHON bit in GIT-BUILD-OPTIONS (did you forget it there, or was it part of some other patch that also didn't get applied?).
It was 1/2 of that series.
Also, I am tempted to move the GIT-BUILD-OPTIONS invocation _up_. It is about reading config and should probably come before we start doing _anything_. So maybe this instead:
<snip the patch> Looks fine to me. No strong opinion on whether the BUILD-OPTIONS thing should be at the beginning of the script, or in the place where you placed it. -brandon